Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-50][UDF Manage] Remove unused udf manage function #16212

Merged
merged 12 commits into from
Jun 26, 2024

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

close #16209

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added UI ui and front end related improvement make more easy to user or prompt friendly backend document 3.3.0 labels Jun 25, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 25, 2024
@SbloodyS SbloodyS self-assigned this Jun 25, 2024
@SbloodyS SbloodyS changed the title [Improvement-16209][UDF Manage] Remove udf manage function [Improvement-16209][UDF Manage] Remove unused udf manage function Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (c7a0994) to head (eb70b38).

Current head eb70b38 differs from pull request most recent head 3afb4c3

Please upload reports for the commit 3afb4c3 to get more accurate results.

Files Patch % Lines
...nscheduler/service/process/ProcessServiceImpl.java 70.00% 2 Missing and 1 partial ⚠️
...pache/dolphinscheduler/spi/enums/ResourceType.java 0.00% 3 Missing ⚠️
...ache/dolphinscheduler/api/audit/OperatorUtils.java 0.00% 0 Missing and 1 partial ⚠️
...ache/dolphinscheduler/plugin/task/sql/SqlTask.java 0.00% 1 Missing ⚠️
...heduler/tools/resource/MigrateResourceService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16212      +/-   ##
============================================
- Coverage     41.35%   41.24%   -0.11%     
+ Complexity     5167     5121      -46     
============================================
  Files          1403     1397       -6     
  Lines         44423    44056     -367     
  Branches       4721     4666      -55     
============================================
- Hits          18372    18173     -199     
+ Misses        24246    24103     -143     
+ Partials       1805     1780      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SbloodyS SbloodyS marked this pull request as ready for review June 25, 2024 11:59
@SbloodyS SbloodyS requested a review from rickchengx June 25, 2024 11:59
@SbloodyS SbloodyS changed the title [Improvement-16209][UDF Manage] Remove unused udf manage function [DSIP-50][UDF Manage] Remove unused udf manage function Jun 25, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS requested a review from Radeity June 26, 2024 07:26
Copy link

sonarcloud bot commented Jun 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit e856681 into apache:dev Jun 26, 2024
62 of 63 checks passed
@SbloodyS SbloodyS deleted the improvement_16209 branch June 26, 2024 13:10
@SbloodyS SbloodyS added the DSIP label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend CI&CD document DSIP e2e e2e test improvement make more easy to user or prompt friendly test UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-50][UDF Manage] Remove udf manage function
5 participants